Skip to content

YARN-10427. Duplicate Job IDs in SLS output#3809

Merged
shuzirra merged 2 commits intoapache:trunkfrom
szilard-nemeth:YARN-10427-2
Dec 16, 2021
Merged

YARN-10427. Duplicate Job IDs in SLS output#3809
shuzirra merged 2 commits intoapache:trunkfrom
szilard-nemeth:YARN-10427-2

Conversation

@szilard-nemeth
Copy link
Contributor

@szilard-nemeth szilard-nemeth commented Dec 16, 2021

Description of PR

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

hadoop-yetus commented Dec 16, 2021

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 35m 17s trunk passed
+1 💚 compile 0m 27s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 0m 24s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 0m 20s trunk passed
+1 💚 mvnsite 0m 28s trunk passed
+1 💚 javadoc 0m 25s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 24s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 0m 46s trunk passed
+1 💚 shadedclient 23m 8s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 22s the patch passed
+1 💚 compile 0m 21s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 0m 21s the patch passed
+1 💚 compile 0m 18s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 0m 18s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 12s /results-checkstyle-hadoop-tools_hadoop-sls.txt hadoop-tools/hadoop-sls: The patch generated 1 new + 22 unchanged - 1 fixed = 23 total (was 23)
+1 💚 mvnsite 0m 21s the patch passed
+1 💚 javadoc 0m 19s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 17s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 0m 50s the patch passed
+1 💚 shadedclient 22m 57s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 12m 3s hadoop-sls in the patch passed.
+1 💚 asflicense 0m 31s The patch does not generate ASF License warnings.
103m 1s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3809/1/artifact/out/Dockerfile
GITHUB PR #3809
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux a7f932245ac0 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 8171e9c
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3809/1/testReport/
Max. process+thread count 521 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3809/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@shuzirra shuzirra merged commit a967033 into apache:trunk Dec 16, 2021
@shuzirra
Copy link

shuzirra commented Dec 16, 2021

@szilard-nemeth thank you for the patch, LGTM+1, merged to trunk.

hotcodemacha pushed a commit to hotcodemacha/hadoop that referenced this pull request Dec 22, 2021
@szilard-nemeth @hotcodemacha
YARN-10427. Duplicate Job IDs in SLS output (apache#3809). Contribute…
a8635b8 
…d by Szilard Nemeth
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
@szilard-nemeth
YARN-10427. Duplicate Job IDs in SLS output (apache#3809). Contribute…
c44716c 
…d by Szilard Nemeth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuzirra shuzirra shuzirra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@szilard-nemeth @hadoop-yetus @shuzirra